refactor: restructure code system upload API and remove user_id fields #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganized the construe upload API to simplify request structure and improve asynchronous processing flow. Removed user_id fields from multiple template types across the SDK to streamline data models. Key changes: - Simplified upload request structure with unified UploadRequest interface - Changed upload behavior to always return 202 and process asynchronously - Removed user_id fields from ChatMessageTemplate, ChatSessionTemplate, and other templates - Updated documentation to reflect asynchronous processing model - Reorganized type exports and moved UploadRequest to client/requests directory - Added name and version fields to upload response for better tracking 🌿 Generated with Fern
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| file: "file", | ||
| code_col: "code", | ||
| desc_col: "description", | ||
| }; |
There was a problem hiding this comment.
Test mocks 200 but API now returns 202
Low Severity
The happy-path test for uploadCodeSystem mocks a statusCode(200) response, but the documentation, code comments, and PR description all state the endpoint now always returns 202 to indicate asynchronous processing. The response body was correctly updated (from "success" to "processing"), but the status code was not changed to match. This means the test doesn't validate the actual wire behavior of the 202 async flow.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganized the construe upload API to simplify request structure and improve
asynchronous processing flow. Removed user_id fields from multiple template
types across the SDK to streamline data models.
Key changes:
🌿 Generated with Fern
Note
Medium Risk
Introduces breaking type/model changes and changes the upload request/response contract for
uploadCodeSystem, which may require downstream code updates despite being largely SDK-surface refactoring.Overview
Bumps the SDK to
6.0.0and refactorsconstrue.uploadCodeSystemto use a singleUploadRequesttype (moved underconstrue/client/requests) with aformatenum and optional CSV/JSON-specific fields, removing the prior format-specific union types and theasyncupload flag.Updates behavior/docs/tests to reflect uploads being always asynchronous (returning immediately with processing status and requiring polling for readiness), and expands
ConstrueUploadCodeSystemResponseto includenameandversion. Removesuser_idfrom multiple template/response models (agent chat messages/sessions, FHIR provider templates, summary templates, MCP server/tool responses, workflows) and adjusts wire tests accordingly.Written by Cursor Bugbot for commit d9db363. This will update automatically on new commits. Configure here.